Containerise dependencies required to run tasks in dev workflow #53
Conversation
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
…/platform-examples into em/dockerize-wg-easy-dependencies
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
applications/wg-easy/Taskfile.yaml
Outdated
| # GCP default configuration | ||
| GCP_PROJECT: '{{.GCP_PROJECT | default "replicated-qa"}}' | ||
| GCP_ZONE: '{{.GCP_ZONE | default "us-central1-a"}}' | ||
| VM_NAME: '{{.VM_NAME | default (printf "%s-dev" (or (env "GUSER") "user"))}}' | ||
|
|
||
| # Docker workflow configuration | ||
| IMAGE_NAME: ttl.sh/wg-easy-dev |
There was a problem hiding this comment.
We really shouldn't be using ttl.sh here, it's fine for development but it needs to be available somewhere else for the actual workflow. Is this currently just for you to test and you intend to move it later?
There was a problem hiding this comment.
This is currently for test until we decide on
- if we need to host this image. We need to weigh the need to host the image vs users needing to build the image which take a minute.
- what OCI registry - docker hub? replicated? all of the above?
There was a problem hiding this comment.
Can we build the image and have it pushed to ghcr.io right here on this repo?
I'm fine with starting with a local build and following up with the auto-build on ghcr or if it's easy enough just build it anytime the Containerfile changes on merge to main.
I added a podman based image build/push on troubleshoot-mcp-server which might be very close to what you would need. https://github.com/chris-sanders/troubleshoot-mcp-server/blob/main/.github/workflows/publish-container.yaml
Signed-off-by: Scott Rigby <[email protected]>
banjoh
changed the title
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
| start: | ||
| desc: Start development container in background | ||
| silent: true | ||
| cmds: | ||
| - task: start-implementation | ||
|
|
||
| # Start development container in background. | ||
| # It's internal because it's used by shell and start tasks. | ||
| start-implementation: |
There was a problem hiding this comment.
I'm not following why can't this all just be in the "start" task? Task can call and require each other what does having an internal task buy you here if the real start task is just calling the internal one anyway?
There was a problem hiding this comment.
I've DRY'd this bit some more
Co-authored-by: Scott Rigby <[email protected]>
Co-authored-by: Scott Rigby <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
banjoh
force-pushed
the
em/dockerize-wg-easy-dependencies
branch
from
41ab16e to
3c23789
Compare
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
When starting the development container, check if the image exists locally before pulling or building it. Signed-off-by: Evans Mungai <[email protected]>
dev:shell automatically builds the image if it doesn't exist locally Signed-off-by: Evans Mungai <[email protected]>
banjoh
force-pushed
the
em/dockerize-wg-easy-dependencies
branch
from
e1d26a8 to
a3ef59e
Compare
ghcr.io/replicatedhq/platform-examples/wg-easy-tools:latestimage. The image is also tagged withsha-<commit>.